feat: update lifecycle logic to handle - after prefix - #188
Open
Larry1123 wants to merge 1 commit into
Open
Conversation
Larry1123
changed the title
Author
|
I am unsure why eslint is failing it is not failing locally when I run it. |
Collaborator
|
Any docs suggest |
Author
|
No I have not. I had looked over a lot of names that come up and I felt that even if it was used most uses causes like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think that this should affect any. I am working on a plugin for yarn 2 to add lifecycle handing.
As they say in their docs using just
preandpostcan have odd side effects. The plugin I am creating will usepre-andpost-as the prefix. I use this package and wanted to keep using it without patching it per project to make use of it.From yarn docs.
In particular, we intentionally don't support arbitrary pre and post hooks for user-defined scripts (such as prestart). This behavior, inherited from npm, caused scripts to be implicit rather than explicit, obfuscating the execution flow. It also led to surprising executions with yarn serve also running yarn preserve.